Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

developers package requirments txt file added #5

Merged
merged 5 commits into from
Oct 2, 2018
Merged

developers package requirments txt file added #5

merged 5 commits into from
Oct 2, 2018

Conversation

mattclifford1
Copy link
Contributor

No description provided.

So-Cool
So-Cool requested changes Sep 26, 2018
View reviewed changes
Copy link
Member

@So-Cool So-Cool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have 2 minor comments:

  1. Please add specific versions for every package that is listed, e.g. codecov==0.0.0. You can find out the version of the package by executing pip list.
  2. Please order the requirements alphabetically.

@So-Cool So-Cool mentioned this pull request Sep 26, 2018
Open
@So-Cool
Copy link
Member

So-Cool commented Sep 26, 2018

Great. One more issue: the requirements are Python conditional statements, hence they should use == instead of =, e.g. codecov==0.0.0.

@So-Cool
Copy link
Member

So-Cool commented Sep 26, 2018

I'm OK with it unless @alexhepburn has some requirements that are not there.

@So-Cool So-Cool merged commit 08ad514 into fat-forensics:dev Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@So-Cool So-Cool So-Cool approved these changes

@alexhepburn alexhepburn Awaiting requested review from alexhepburn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattclifford1 @So-Cool