clean up

trackscape-discord-api/src/controllers/application_data_controller.rs

@@ -1,7 +1,6 @@
 use actix_web::{get, web, Error, HttpResponse, Scope};
-use log::info;
 use serde::{Deserialize, Serialize};
-use trackscape_discord_shared::database::clan_mates::{ClanMateModel, ClanMates};
+use trackscape_discord_shared::database::clan_mates::ClanMateModel;
 use trackscape_discord_shared::database::BotMongoDb;
 use web::Data;
 

trackscape-discord-shared/src/database/pb_activities_db.rs

@@ -1,6 +1,6 @@
 use bson::serde_helpers::serialize_object_id_as_hex_string;
 use bson::DateTime;
-use futures::{TryFutureExt, TryStreamExt};
+use futures::TryStreamExt;
 use mockall::predicate::*;
 use mongodb::bson::doc;
 use mongodb::options::FindOptions;

trackscape-discord-ui/src/components/clan/BroadcastItem.vue

@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import type { Broadcast } from '@/services/TrackscapeApiTypes';
-import { type PropType, ref } from 'vue';
+import { type PropType } from 'vue';
 
 const props = defineProps({
   broadcast: {

trackscape-discord-ui/src/router/index.ts

@@ -4,7 +4,7 @@ import ClanRoutes from './clans';
 
 const router = createRouter({
   history: createWebHistory(import.meta.env.BASE_URL),
-  scrollBehavior(to, from, savedPosition) {
+  scrollBehavior() {
     // always scroll to top
     return { top: 0 };
   },

trackscape-discord-ui/src/views/clans/clan/ClanView.vue

@@ -1,6 +1,5 @@
 <script setup lang="ts">
-
-import {useRoute} from "vue-router";
+import { useRoute } from 'vue-router';
 import PageTitle from "@/components/PageTitle.vue";
 import TrackscapeApiClient from "@/services/TrackscapeApiClient";
 import {ref} from "vue";
@@ -56,6 +55,7 @@ const tabMenus = [
     active: false,
     childrenNames: [
       'collection-log',
+      'personal-best'
     ]
   },
 ];
@@ -108,7 +108,7 @@ const tabMenus = [
       <router-link v-for="(tabMenu,index) in tabMenus"
                    :key="index"
                    :to="{name: tabMenu.routeName, params: {clanId: clanId}}"
-                   :class="['tab', {'tab-active': route.name === tabMenu.routeName} || tabMenu.childrenNames.includes(route.name)]">{{tabMenu.name}}</router-link>
+                   :class="['tab', {'tab-active': route.name === tabMenu.routeName}, {'tab-active': tabMenu.childrenNames.includes(route.name?.toString() ?? '')}]">{{tabMenu.name}}</router-link>
     </div>
 
     <router-view v-slot="{ Component}" >

trackscape-discord-ui/src/views/clans/clan/subviews/LeaderboardView.vue

@@ -1,11 +1,8 @@
 <script setup lang="ts">
-import TrackscapeApiClient from "@/services/TrackscapeApiClient";
-import type {ClanDetail, ClanMateCollectionLogTotalsView} from "@/services/TrackscapeApiTypes";
+import type {ClanDetail} from "@/services/TrackscapeApiTypes";
 import type {PropType} from "vue";
 import {useRoute} from "vue-router";
 import {ref} from "vue";
-import DataTable from "@/components/General/DataTable.vue";
-import SkeletonTable from "@/components/General/SkeletonTable.vue";
 import PersonalBestActivitySelect from '@/components/clan/PersonalBestActivitySelect.vue';
 
 

trackscape-discord-ui/src/views/clans/clan/subviews/leaderboards/PersonalBestLeaderboardView.vue

@@ -1,13 +1,11 @@
 <script setup lang="ts">
 import type { ClanDetail } from '@/services/TrackscapeApiTypes';
 import type {PropType} from "vue";
-import {useRoute} from "vue-router";
 import {ref} from "vue";
 import DataTable from "@/components/General/DataTable.vue";
 import SkeletonTable from "@/components/General/SkeletonTable.vue";
 import { usePbStore } from '@/stores/PbStore';
 import ClanMateWithRank from '@/components/clan/ClanMateWithRank.vue';
-import { it } from 'vitest';
 
 const store = usePbStore();
 
@@ -23,9 +21,6 @@ let clan = ref<ClanDetail>();
 
 if (props.clanDetail) {
   clan.value = props.clanDetail;
-} else {
-  const route = useRoute();
-  const clanId = route.params.clanId as string;
 }
 
 const columns = [