Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting check failing on Setting.secret_token.present? #1206

Closed
ferrisoxide opened this issue Dec 5, 2023 · 1 comment
Closed

Setting check failing on Setting.secret_token.present? #1206

ferrisoxide opened this issue Dec 5, 2023 · 1 comment

Comments

@ferrisoxide
Copy link
Contributor

ferrisoxide commented Dec 5, 2023

The check for SecretTokenGenerator#token_exists? fails when there is no settings.yml file present (or the value isn't in the database).

The underlying issue is the call to settings.value fails with a "NoMethodError: undefined method 'value' for nil:NilClass" when the setting is missing. The secret_token.rb initializer fails on startup / deploy.

PR to address the issue here: #1205

@ferrisoxide
Copy link
Contributor Author

Closing. Fix has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant