Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI won't update on comment email 500 failure #403

Open
ain opened this issue Jan 17, 2015 · 1 comment
Open

GUI won't update on comment email 500 failure #403

ain opened this issue Jan 17, 2015 · 1 comment

Comments

@ain
Copy link
Contributor

ain commented Jan 17, 2015

When emails are pushed on a new comment to multiple accounts (e.g. 3) and server throws up with 500 (reason unclear), it doesn't make it back to the GUI and submission loader runs infinitely:

screen shot 2015-01-17 at 13 31 02

Log:

Started POST "/comments" for <IP> at 2015-01-17 12:30:43 +0000
Processing by CommentsController#create as JS
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"R4Gy3PQOwaRDvnoYx3iiyEZYeLGPyPmGoF51nwGWQ6c=", "comment"=>{"commentable_id"=>"77", "commentable_type"=>"Account", "comment"=>"Testing against processing timeout as by DRMS-50"}, "commit"=>"Add Note"}
  Rendered subscription_mailer/comment_notification.text.erb (0.9ms)

Sent mail to user0@email.com (3071.9ms)
  Rendered subscription_mailer/comment_notification.text.erb (0.8ms)

Sent mail to user1@email.com (2984.7ms)
  Rendered subscription_mailer/comment_notification.text.erb (0.7ms)

Sent mail to user2@email.com (2977.4ms)
  Rendered subscription_mailer/comment_notification.text.erb (0.7ms)

Sent mail to user3@email.com (30012.2ms)
Completed 500 Internal Server Error in 39154.5ms

Net::OpenTimeout (execution expired):
  app/models/polymorphic/comment.rb:49:in `block in notify_subscribers'
  app/models/polymorphic/comment.rb:47:in `each'
  app/models/polymorphic/comment.rb:47:in `notify_subscribers'
  app/controllers/comments_controller.rb:57:in `create'

I'd propose to catch this and act accordingly in GUI as well.

@steveyken steveyken added the UI label Jan 20, 2015
@steveyken
Copy link
Member

Agreed. Shouldn't be 500 if the mailer is offline or doesn't respond etc... just deferred for later.

@CloCkWeRX CloCkWeRX added this to To Do in Improved UI Jan 20, 2018
@johnnyshields johnnyshields modified the milestone: 0.20.0 Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Improved UI
  
To Do
Development

No branches or pull requests

3 participants