Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a reference Sphere class #18

Closed
leouieda opened this issue Jan 10, 2020 · 2 comments · Fixed by #42
Closed

Include a reference Sphere class #18

leouieda opened this issue Jan 10, 2020 · 2 comments · Fixed by #42
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)

Comments

@leouieda
Copy link
Member

As shown in #13, flattening of 0 leads to not-a-number in the computations due to division by the first eccentricity (which is 0). In these cases, it would make more sense to have a boule.Sphere class that mirrors the Ellipsoid but is much simpler:

Sphere(radius=..., geocentric_grav_const=..., angular_velocity=...)

All the eccentricities, gravity at the pole and equator, and coordinate conversions aren't needed. The forward modelling equations are also simpler (should be implemented in Sphere.normal_gravity).

@leouieda leouieda added enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project) help wanted labels Jan 10, 2020
@welcome
Copy link

welcome bot commented Jan 10, 2020

👋 Thanks for opening your first issue here! Please make sure you filled out the template with as much detail as possible.

You might also want to take a look at our Contributing Guide and Code of Conduct.

@MarkWieczorek
Copy link
Contributor

I think that a Sphere class would be very useful. In particular, I would like to add the reference spheres for Mercury, Venus, and the Moon. For these objects, the rotation rate is very small, and the non-hydrostatic component of the degree-2 shape is larger than the theoretical hydrostatic shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants