Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation section about passing arguments to requests #187

Open
leouieda opened this issue Jun 22, 2020 · 0 comments
Open

Documentation section about passing arguments to requests #187

leouieda opened this issue Jun 22, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@leouieda
Copy link
Member

Description of the desired feature

Sometimes we may need to specify arguments to requests.get when downloading a file (#186 for example). This can be done with keyword arguments in HTTPDownloader. The example in the docs is passing in authentication but it would be good to say that we can pass any argument. Maybe adding a section "Passing parameters to downloaders" (or something better) after "Downloaders and authentication" to say that, in fact, we can pass anything like verify=False to skip SSL authentication (which is NOT recommended by may be required).

Are you willing to help implement and maintain this feature? Yes but welcome others to do this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant