New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation for geographic coordinates conversion #172
Comments
The geographic -> geocentric spherical conversion relies on the ellipsoid parameters, which is in Harmonica for normal gravity. We could do that here and ask for pyproj or cartopy ellipsoids but I'm not sure how well that would work. |
I don't think having repeated code would be a good choice. Giving second thoughts to this issue, I realize that even the geographic -> geocentric spherical conversion is a mere geometry operation on coordinates, it would rarely be used in Verde. @leouieda if you agree we could close this issue. |
Is there a possibilty to use geographical coordinates in cKDTree calculations for distance? Pyproj has implemented these. |
@ahartikainen Do you have a link to these calculations? In the |
Sorry, I meant that distance calculations can be done with pyproj, but I'm not sure how we could use those in KDTree structure. |
@ahartikainen not that I'm aware. I wondered if we could use great circle distances but it seems like there is no easy way to plug a custom distance function. |
I agree. This is common in global gravity using tesseroids but probably not much else. |
Description of the desired feature
The geographic coordinates conversion have been implemented on Harmonica.
I don't remember exactly why we added the functions there and not on Verde.
Would it be Verde a better place for them?
The text was updated successfully, but these errors were encountered: