Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for geographic coordinates conversion #172

Closed
santisoler opened this issue Mar 15, 2019 · 7 comments
Closed

Add implementation for geographic coordinates conversion #172

santisoler opened this issue Mar 15, 2019 · 7 comments
Labels
enhancement Idea or request for a new feature

Comments

@santisoler
Copy link
Member

Description of the desired feature

The geographic coordinates conversion have been implemented on Harmonica.
I don't remember exactly why we added the functions there and not on Verde.
Would it be Verde a better place for them?

@leouieda leouieda added the enhancement Idea or request for a new feature label Mar 20, 2019
@leouieda
Copy link
Member

The geographic -> geocentric spherical conversion relies on the ellipsoid parameters, which is in Harmonica for normal gravity. We could do that here and ask for pyproj or cartopy ellipsoids but I'm not sure how well that would work.

@santisoler
Copy link
Member Author

santisoler commented Mar 21, 2019

I don't think having repeated code would be a good choice. Giving second thoughts to this issue, I realize that even the geographic -> geocentric spherical conversion is a mere geometry operation on coordinates, it would rarely be used in Verde.

@leouieda if you agree we could close this issue.

@ahartikainen
Copy link

Is there a possibilty to use geographical coordinates in cKDTree calculations for distance?

Pyproj has implemented these.

@djhoese
Copy link
Contributor

djhoese commented Mar 21, 2019

@ahartikainen Do you have a link to these calculations? In the pyresample project we've always converted lon/lats to xyz coordinates before putting them in a kdtree.

@ahartikainen
Copy link

Sorry, I meant that distance calculations can be done with pyproj, but I'm not sure how we could use those in KDTree structure.

@leouieda
Copy link
Member

@ahartikainen not that I'm aware. I wondered if we could use great circle distances but it seems like there is no easy way to plug a custom distance function.

@leouieda
Copy link
Member

@leouieda if you agree we could close this issue.

I agree. This is common in global gravity using tesseroids but probably not much else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea or request for a new feature
Projects
None yet
Development

No branches or pull requests

4 participants