This repository has been archived by the owner on Oct 11, 2018. It is now read-only.
provider/sl: fixes for copy #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following Softlayer API error: There are no existing source locations available for image template transfer. (code="SoftLayer_Exception_Public")
Fixes the following Softlayer API error: There is currently an outstanding transaction for this image template. (code="SoftLayer_Exception_Virtual_Guest_Block_Device_Template_Group_ActiveTransactionExists")
| return nil | ||
| } | ||
|
|
||
| time.Sleep(5 * time.Second) |
There was a problem hiding this comment.
Why didn't you use time.Tick() together with timeout. So it would test every 5 seconds, but if there is any timeout it would just return.
There was a problem hiding this comment.
I'm don't know how to user ticker to not have to wait the first tick - if there's no transactions in progress the above loop returns right away, with ticker it'll sleep initial 5s regardless of the state.
There was a problem hiding this comment.
Right. I think I new a solution for it but it's not worth it. Thanks for the hard work btw, much appreciated. Merging it :)
|
Hi @rjeczalik Thanks! Sorry for the late response, I just could look at it :) This looks very good, LGTM. Just added a note, let me know what you think about it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @fatih!
Various fixes for the Softlayer client, improves support for copying the images across datacenters.
Tested manually with all datacenters, funny fact - it does not work with
dal02,dal04anddal07as Softlayer claims they're not valid datacenters (:D).Besides that works pretty good.
Happy New Year!