Skip to content

Commit

Permalink
Fix installing gocode on Windows (#1606)
Browse files Browse the repository at this point in the history
Was missing a space in composing the command, so this would get run:

  go get -v -u -ldflags -H=windowsgui"github.com/nsf/gocode"
  • Loading branch information
arp242 committed Dec 10, 2017
1 parent 2a42722 commit b50d8f2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -59,6 +59,8 @@ BUG FIXES:
[[GH-1581]](https://github.com/fatih/vim-go/pull/1581).
* Add `g:go_highlight_function_arguments` to highlight function arguments.
[[GH-1587]](https://github.com/fatih/vim-go/pull/1587).
* Fix installation of `gocode` on MS-Windows.
[[GH-1606]](https://github.com/fatih/vim-go/pull/1606).

BACKWARDS INCOMPATIBILITIES:

Expand Down
2 changes: 1 addition & 1 deletion plugin/go.vim
Expand Up @@ -146,7 +146,7 @@ function! s:GoInstallBinaries(updateBinaries, ...)
echo "vim-go: ". binary ." not found. Installing ". importPath . " to folder " . go_bin_path
endif

let out = go#util#System(cmd . l:goGetFlags . shellescape(importPath))
let out = go#util#System(printf('%s %s %s', cmd, l:goGetFlags, shellescape(importPath)))
if go#util#ShellError() != 0
echom "Error installing " . importPath . ": " . out
endif
Expand Down

0 comments on commit b50d8f2

Please sign in to comment.