Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using :GoRun in terminal mode N times opens N location list windows #1720

Closed
bhcleek opened this issue Mar 19, 2018 · 0 comments · Fixed by #1721
Closed

Using :GoRun in terminal mode N times opens N location list windows #1720

bhcleek opened this issue Mar 19, 2018 · 0 comments · Fixed by #1721
Assignees

Comments

@bhcleek
Copy link
Collaborator

bhcleek commented Mar 19, 2018

What did you do? (required. The issue will be closed when not provided.)

#!/bin/sh

DIR=$(mktemp -d -t vimgo-term-mode)
printf "using %s\n" "$DIR"

cat <<EOF > "$DIR/main.go"
package main

import "fmt"

func main() {
	abc
	greating := "hello, world!"
	fmt.Printf(greating)
}
EOF

cd "$DIR"
nvim -c 'let g:go_term_mode="botright split"' main.go

And then run :GoRun twice.

What did you expect to happen?

A single location list window to display the error reading undefined: abc.

What happened instead?

Two location windows display the error reading undefied: abc.

Configuration (MUST fill this out):

  • Vim version (first two lines from :version):
    NeoVim v0.2.2

  • Go version (go version):
    1.9.4

  • Go environment (go env):

  • vim-go version:
    master as of d2b0a234ffb5441a3488c78fe8e5f551ddbdd454

  • vimrc you used to reproduce (use a minimal vimrc with other plugins disabled; do not link to a 2,000 line vimrc):

@bhcleek bhcleek self-assigned this Mar 19, 2018
@bhcleek bhcleek added the bug label Mar 19, 2018
bhcleek added a commit to bhcleek/vim-go that referenced this issue Mar 19, 2018
* Explicitly close the terminal window instead of assuming the terminal
  window is the current window and closing that.
* Eliminate the outstanding job list in favor of using a more object
  oriented like approach.
* Make sure the correct location list gets used instead of assuming that
  the current window is the window whose location list should be used.

Fixes fatih#1720
@bhcleek bhcleek added the neovim label Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant