-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI is blocked whilst gopls
is being initialized
#2414
Comments
I use vim-go in a large repository daily without blocking behavior when opening a Go file. To the best of my knowledge, the delay caused by using gopls in a large repo has been resolved since https://github.com/fatih/vim-go/pull/2371/files. It's curious that you're still seeing a delay 🤔 |
I can confirm this: it takes 1-2 seconds to initialize gopls with latest vim-go. The initialization blocks the UI thread, which makes this painful every time I open a |
@motiejus are you using the latest commit on master or are you using the latest release of vim-go? |
I dove a little deeper. Turns out, in my environment, I will dig into this more internally, but I am taking back my comment. |
Thanks for confirming. I'm going to close this again, but please feel free to open a new issue if your analysis leads you to think this is a problem with vim-go again. |
It happens for me if I use vim to open a file under a large repo when I enter |
@XavierCheng1996 I encountered the same behavior you described: "stuck forever saying |
Currently
vim-go
is blocking the UI whilstgopls
is loading. Although I understand thatgopls
is essential for this plugin to function well, I think that the user should not have to wait for the server to start before they can start editing. This was not happening beforegopls
support and I think that this is a regression from the previous user experience.Would it be possible to disable
gopls
with a configuration switch or make it non blocking? I know that there is already #2250, but I thought that creating a new issue better in this case we have a performance degradation.What did you do? (required: The issue will be closed when not provided)
Open a a go file in a large repository.
What did you expect to happen?
I can edit the file immediately.
What happened instead?
gopls
is being loaded for about a second and the UI is unresponsive.Configuration (MUST fill this out):
Default
vim-go
configuration.vim-go version:
Latest master.
vimrc
you used to reproduce (use a minimal vimrc with other plugins disabled; do not link to a 2,000 line vimrc):Vim version (first three lines from
:version
):Go version (
go version
):The text was updated successfully, but these errors were encountered: