Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with gometalinter #320

Closed
noonien opened this issue Feb 16, 2015 · 15 comments
Closed

Integration with gometalinter #320

noonien opened this issue Feb 16, 2015 · 15 comments
Labels

Comments

@noonien
Copy link

noonien commented Feb 16, 2015

Are there any plans to integrate with gometalinter?

@fatih
Copy link
Owner

fatih commented Feb 16, 2015

Thanks for bringing it up. I don't think to integrate it right now. Let's wait until it get's some momentum. Also each linter has his own format and for some of them it requires special formatting rules. I don't want to add them right now.

@fatih fatih closed this as completed Feb 16, 2015
@fatih fatih mentioned this issue Feb 16, 2015
@alecthomas
Copy link

Also each linter has his own format and for some of them it requires special formatting rules.

That is actually the very problem that gometalinter solves. It runs errcheck, structcheck, vet, deadcode, golint, gotype, defercheck, varcheck, gocyclo, and go-nyet and normalises their output to a single format:

<file>:<line>:[<col>]: <message> (<linter>)

@noonien
Copy link
Author

noonien commented May 5, 2015

Has this been given any further consideration? As @alecthomas suggested, since I've created this issue, gometalinter has standardized its output format, and is similar to output given from gofmt.

Having the ability to run all linters on save would be a great benefit to any project.

Please reconsider. Thank you!

@tsenart
Copy link

tsenart commented Jul 24, 2015

+1

1 similar comment
@xla
Copy link

xla commented Jul 26, 2015

+1

@fatih fatih reopened this Jul 26, 2015
@fatih fatih added the feature label Jul 26, 2015
@fatih
Copy link
Owner

fatih commented Jul 26, 2015

I'll reopen and add label it as feature. Will tackle it later or soon :)

@xla
Copy link

xla commented Jul 26, 2015

@fatih Thanks for the follow-up!

@tgrosinger
Copy link
Contributor

+1 this feature request. I was going to open an issue asking for integrating go-vet and go-lint on save (similar to what go-plus does for Atom), but this sounds like it would be even better in the long run.

@langston-barrett
Copy link

+1

2 similar comments
@josephglanville
Copy link

+1

@karlmutch
Copy link

+1

@fatih
Copy link
Owner

fatih commented Sep 28, 2015

It's on my schedule, I didn't forget it, no need for the +1's ;)

@fatih
Copy link
Owner

fatih commented Sep 28, 2015

A related issue: alecthomas/gometalinter#49

@fatih fatih mentioned this issue Sep 29, 2015
6 tasks
@fatih
Copy link
Owner

fatih commented Sep 29, 2015

I've started to implement gometalinter and finally have a working version here: #553 Please try to use it and comment on any issues you find :)

@fatih
Copy link
Owner

fatih commented Sep 30, 2015

This is now merged to master. Please check #553 or the docs how to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants