Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoErrCheck only opens a new window the first time it is run #34

Closed
rlmcpherson opened this issue Mar 31, 2014 · 9 comments
Closed

GoErrCheck only opens a new window the first time it is run #34

rlmcpherson opened this issue Mar 31, 2014 · 9 comments

Comments

@rlmcpherson
Copy link

When running :GoErrCheck, the first time it is run a new window is opened listing the errors found. Running it subsequent times, though, no window opens listing the errors.

Note: it's quite possible that I have something misconfigured as I just began using vim-go. Overall it's a great tool and more than replaces the extensive go vim config I was previously using. Thanks for creating it.

@rlmcpherson rlmcpherson changed the title GoErrCheck only opens a new the first time it is run GoErrCheck only opens a new window the first time it is run Mar 31, 2014
@fatih
Copy link
Owner

fatih commented Apr 1, 2014

Can you give me some example snippets that I can try?

@fatih
Copy link
Owner

fatih commented Apr 1, 2014

Can you please pull the latest master and try again?

@rlmcpherson
Copy link
Author

I just pulled the latest master (commit c135257), and ran :GoUpdateBinaries. Now the original issue does not occur, but selecting an error does not open the correct file and location. There is also an error: "Go test returned error" (see below)

screenshot 2014-04-01 12 06 55

As far as examples, I see this for all unchecked errors found by goerrcheck. For example, in this code where 'defer resp.Body.Close()' is called without checking the error from Close(): https://github.com/rlmcpherson/s3gof3r/blob/9c537e1afe03bd3cb0ca582002a6d2ef3eb7beef/auth.go#L42

@fatih
Copy link
Owner

fatih commented Apr 1, 2014

Ok I'll try it on your package. Seems it does work but doesn't parse the file somehow. The "go test returned error" is a default error I'll fix it now.

@fatih fatih closed this as completed in f632c98 Apr 1, 2014
@fatih
Copy link
Owner

fatih commented Apr 1, 2014

Can you pull latest master and try again please ?

@fatih
Copy link
Owner

fatih commented Apr 1, 2014

Btw here is how it's looks like for me after the fix:

screen shot 2014-04-02 at 2 00 03 am

@rlmcpherson
Copy link
Author

Everything seems to be working after pulling the latest master, thanks!

I do see an error message, but it does not impact any functionality.
screenshot 2014-04-02 11 33 01

@fatih
Copy link
Owner

fatih commented Apr 2, 2014

Ah yes, this error is called explicitly by vim-go :) I think I should remove it, people would think it's a problem and actually it's just indicating that GoErrCheck found some errors.

@rlmcpherson
Copy link
Author

Good to know it's not indicating a problem. Thanks for the rapid fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants