Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full error messages from GoRename #566

Closed
kalafut opened this issue Oct 10, 2015 · 4 comments · Fixed by #577
Closed

Show full error messages from GoRename #566

kalafut opened this issue Oct 10, 2015 · 4 comments · Fixed by #577
Labels
bug

Comments

@kalafut
Copy link
Contributor

kalafut commented Oct 10, 2015

gorename "conflict" and "reference will become shadowed" errors (and maybe others) list the conflict points on multiple lines. vim-go only shows the first line of the output which usually doesn't haven't anything helpful. During complex refactors, I find myself running gorename on the command line to get at the full error message. It would be good if the plugin expose the full output.
@fatih
Copy link
Owner

fatih commented Oct 11, 2015

Hi @kalafut

This is a great catch. Right now we don't do any kind of error message parsing for GoRename. Could you please paste some error message examples that I can check? Also a test case (repo maybe) where I can test it would be helpful.

@fatih fatih added the bug label Oct 11, 2015
@kalafut
Copy link
Contributor Author

kalafut commented Oct 11, 2015

I've created a gist of a sample file that causes this type of error.

fatih added a commit that referenced this issue Oct 18, 2015
@fatih
gorename: create and populate errors in quickfix window
3422721 
This fixes #566 and also introduces parsing errors for `:GoRename`
command. Now it's acting like our other commands such as `:GoTest`,
`:GoBuild`, etc.. It fully parses the errors and jumps to the first
error it founds.
@fatih fatih mentioned this issue Oct 18, 2015
Merged
@fatih
Copy link
Owner

fatih commented Oct 18, 2015

Hi @kalafut

Thanks for the test case. I've fixed it with the the PR #577. Now it parses the error and outputs it in a quickfix window. You can interact with the window just like you did with the other tools. Please test and let me know if something is wrong:

screen shot 2015-10-18 at 7 03 04 pm

@kalafut
Copy link
Contributor Author

kalafut commented Oct 18, 2015

Just tried it out and it seems to work fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gorename: create and populate errors in quickfix window fatih/vim-go
2 participants
@kalafut @fatih