handle :GoDef from modified buffer #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I inadvertently made these changes on an older version of master than I should have. I'm working to fix them now, and will push a rebased commit once I have conflicts resolved. |
Handle jumping to type definitions from a modified buffer. When the definition is in the same file, skip trying to open the file that contains the definition - just set the cursor position. When the definition is in a different file and the current buffer has unsaved modifications, use :hide edit instead of :edit. Fixes fatih#1125
bhcleek
force-pushed
the
fix-godef-split
branch
from
5172db2
to
973ba8c
Compare
|
I've rebased on top of current master. |
|
Thanks @bhcleek. Just had time to look after this. Confirmed that it was due |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle jumping to type definitions from a modified buffer. When the
definition is in the same file, skip trying to open the file that
contains the definition - just set the cursor position. When the
definition is in a different file and the current buffer has unsaved
modifications, use :hide edit instead of :edit.
Fixes #1125