Add support for quicktemplate syntax to gohtmltmpl filetype #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fairly popular template package. It would be great to support this. This causes no conflicts that I can see and is a very simple addition. For more details see: [quicktemplate](https://github.com/valyala/quicktemplate)
|
Thanks @codelitt for the PR. I don't think I want to merge this. This can be perfectly provdided by an external plugin. It's an addition for an additional 3rd party engine, and I'm not using it as well. Merging this means I have to maintain it for many months and even years. I hope you understand my decision. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly popular template package. It would be great to
support this. This causes no conflicts that I can see and is a very
simple addition. For more details see: quicktemplate