path: return the unmodified GOPATH if autodetect is disabled #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2017
myitcv
reviewed
May 8, 2017
| @@ -134,8 +128,8 @@ function! go#path#BinPath() abort | |||
| elseif $GOBIN != "" | |||
| let bin_path = $GOBIN | |||
| else | |||
| " GOPATH (user set or default GO) | |||
| let bin_path = expand(go#path#Default() . "/bin/") | |||
| let go_paths = split(go#path#Default(), go#util#PathListSep()) | |||
There was a problem hiding this comment.
@fatih very much a drive-by comment... i.e. I haven't spent a huge amount of time looking into the context.
But can you not use go list to find the location of a binary?
go list -f '{{.Dir}}' github.com/nsf/gocodeThat way you can avoid any assumptions about which part of GOPATH to use...
There was a problem hiding this comment.
@myitcv this returns the path where the binaries might be installed, not the path of the binary itself. However I assume we can use your approach inside CheckBinPath() where it looks for the path of the binary itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1257