Use a different template for test files #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih
reviewed
Jun 5, 2017
templates/hello_world_test.go
Outdated
| import "testing" | ||
|
|
||
| func TestHelloWorld(t *testing.T) { | ||
| t.Fatal("not implemented") |
There was a problem hiding this comment.
I think this should be commented out by default. It's better to give people a clean pkg instead of a test that's fails. Could you comment this out? The function body should be like:
// t.Fatal("not implemented")
fatih
reviewed
Jun 5, 2017
doc/vim-go.txt
Outdated
| default the `hello_world_test.go` file is used. | ||
| > | ||
| let g:go_template_test_file = "hello_world_test.go" | ||
|
|
fatih
reviewed
Jun 5, 2017
doc/vim-go.txt
Outdated
| with a Go code template. By default the template under | ||
| `templates/hello_world.go` is used. This can be changed with the | ||
| |'g:go_template_file'| setting. | ||
| with a Go code template. By default, the templates under `templates` are used. |
There was a problem hiding this comment.
I think under templates folder are used ... is better. People might not know that we have a templates folder.
|
Thanks @bhcleek. A couple of improvements, once you fix them this is good to go |
Use a template more appropriate for test files than templates/hello_world.go when creating a test file in a directory with no Go files present. A new option, g:go_template_test_file, allows users to specify their own template to use.
bhcleek
force-pushed
the
feature-test-template
branch
from
cac97ee
to
f4be8f6
Compare
|
PTAL |
|
Thanks @bhcleek 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a template more appropriate for test files than templates/hello_world.go
when creating a test file in a directory with no Go files present. A new
option, g:go_template_test_file, allows users to specify their own template to
use.
Fixes #1216