Display warning when people use an older Vim #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
reviewed
Oct 19, 2017
plugin/go.vim
Outdated
| echom "Please update your Vim for the best vim-go experience." | ||
| echom "If you really want to continue you can set this to make the error go away:" | ||
| echom " let g:go_no_version_warning = 1" | ||
| echom "Note that some features may error out or behave incorrect." |
There was a problem hiding this comment.
incorrectly instead of incorrect.
plugin/go.vim
Outdated
| " Version 7.4.1689 was chosen because that's what the most recent Ubuntu LTS | ||
| " release (16.04) uses. | ||
| if | ||
| \ !exists('g:go_no_version_warning') && |
There was a problem hiding this comment.
I wouldn't be surprised is someone sets this to 0 to try to re-enable the warning. Maybe just check that it's not 1?
bhcleek
reviewed
Oct 19, 2017
This shows a warning when people use an older Vim version. You can still set `g:go_no_version_warning` to override this, if people really want to continue. I don't think we need to bother documenting that setting in the help page. The version 7.4.1689 was chosen because that's what the latest Ubuntu LTS (16.04) uses, which seems like a reasonable choice. I don't mind using an older version though.
|
@Carpetsmoker @bhcleek Never seen a problem with vim-go and the message freaked me out :) |
|
@nqv yes we do. Unfortunately Vim is moving fast and with every release, old releases tend to work less. You have the option to disable it as you know, so I think that would be the best option. Thanks for your feedback :) |
|
Adding to that, v1.15 is actually broken in versions before Vim 7.4.1546; see #1483. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows a warning when people use an older Vim version. You can still set
g:go_no_version_warningto override this, if people really want to continue. Idon't think we need to bother documenting that setting in the help page.
The version 7.4.1689 was chosen because that's what the latest Ubuntu LTS
(16.04) uses, which seems like a reasonable choice. I don't mind using an older
version though.