Use signs to keep track of breakpoints #1707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1688 Signs already get updated correct when adding/removing lines, so use information from `:sign place` instead of keeping track of our own list of breakpoints. This also makes sure that what the user sees always matches with that Vim/Delve thinks should happen. TODO: needs some more testing. I saw an error or two I didn't have before.
|
Another ping :) |
|
I'm not going to continue working on this; I worked on the debugger initially because I thought it would be useful, but found that it's, well, not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1688
Signs already get updated correct when adding/removing lines, so use
information from
:sign placeinstead of keeping track of our own listof breakpoints. This also makes sure that what the user sees always
matches with that Vim/Delve thinks should happen.
TODO: needs some more testing. I saw an error or two I didn't have
before.