Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache import path lookups results #1713

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Mar 8, 2018

Cache the results of import path lookups so that go list doesn't have to
be run every time linting is run or go#guru#Sameids() is run, because go
list can take a noticeably long time to return results and has to be
executed synchronously for all of its current use cases.

This further reduces the likelihood that characters will be rendered at
the cursor position when in normal mode.

Cache the results of import path lookups so that go list doesn't have to
be run every time linting is run or go#guru#Sameids() is run, because go
list can take a noticeably long time to return results and has to be
executed synchronously for all of its current use cases.

This further reduces the likelihood that characters will be rendered at
the cursor position when in normal mode.
@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #1713 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
- Coverage   19.57%   19.55%   -0.03%     
==========================================
  Files          57       57              
  Lines        4787     4792       +5     
==========================================
  Hits          937      937              
- Misses       3850     3855       +5
Flag Coverage Δ
#nvim 14.94% <0%> (-0.02%) ⬇️
#vim74 17.13% <0%> (-0.02%) ⬇️
#vim80 18.48% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
autoload/go/package.vim 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b0a23...f2b67ea. Read the comment docs.

@fatih
Copy link
Owner

fatih commented Mar 20, 2018

lgtm

@bhcleek bhcleek merged commit 8f72dc9 into fatih:master Mar 20, 2018
@bhcleek bhcleek deleted the cache-import-path branch March 20, 2018 15:46
bhcleek added a commit that referenced this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants