impl: add support to complete packages #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bhcleek
reviewed
Jul 18, 2018
| for pkg in split(globpath(scr_root, a:arglead.'*'), "\n") | ||
| if isdirectory(pkg) | ||
| let pkg .= '/' | ||
| elseif pkg !~ '\.a$' |
There was a problem hiding this comment.
What is this check guarding against? Why not a simple else?
There was a problem hiding this comment.
This part was straight copied from go#path#Complete which we use for :GoImport. I didn't investigated it to be honest :)
There was a problem hiding this comment.
Ah, I thought that might be the case. The code in go#package#Complete looks in $GOPATH/pkg, where there may be *.a files. Since this isn't looking in $GOPATH/pkg, this could be a simple else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1867