go: install tools with their custom names #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're assuming for now to use the same binary name that also matches the
import path. But this is not always the case. To add support for an
experimental `gocode`, we need to install a second binary. This change
will allow us to do it by just adding a line, such as:
\ 'gocode-gomod': ['github.com/stamblerre/gocode'],
This PR splits `go get` command into specific download and install
steps.
A follow up PR to add support for gocode-gomod will follow.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're assuming for now to use the same binary name that also matches the
import path. But this is not always the case. To add support for an
experimental
gocode, we need to install a second binary. This changewill allow us to do it by just adding a line, such as:
This PR splits
go getcommand into specific download and installsteps.
A follow up PR to add support for gocode-gomod will follow.