Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modified buffer as input to gocode-gomod #2091

Merged
merged 1 commit into from
Dec 15, 2018

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Dec 15, 2018

Saving a modified buffer to disk is no longer necessary for
autocompletion with github.com/stamblerre/gocode;
golang.org/x/tools/go/packages now supports overlays, and support for
them was merged to github.com/stamblerre/gocode recently.

Saving a modified buffer to disk is no longer necessary for
autocompletion with github.com/stamblerre/gocode;
golang.org/x/tools/go/packages now supports overlays, and support for
them was merged to github.com/stamblerre/gocode recently.
@bhcleek bhcleek merged commit 9cae5f1 into fatih:master Dec 15, 2018
@bhcleek bhcleek deleted the gocode-gomod/overlay branch December 15, 2018 17:04
bhcleek added a commit that referenced this pull request Dec 15, 2018
@bhcleek
Copy link
Collaborator Author

bhcleek commented Dec 15, 2018

/cc @JedBeom @myitcv

@myitcv
Copy link

myitcv commented Dec 15, 2018

Awesome news. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants