add initial support for gopls #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract function to URI encode strings and add the decoding function, too. Use the new uri encoding function when reporting a GitHub issue. changes. Lines starting
larrylv
reviewed
Mar 12, 2019
| if has_key(l:response, 'id') && has_key(self.handlers, l:response.id) | ||
| try | ||
| if has_key(l:response, 'error') | ||
| call go#util#EchoError(l:response.message) |
There was a problem hiding this comment.
@bhcleek Should this be call go#util#EchoError(l:response.error)? I'm getting this when the response has error:
E716: Key not present in Dictionary: message)
E116: Invalid arguments for function go#util#EchoError
btw, thank you for adding the gopls support!
There was a problem hiding this comment.
yes! I've updated master accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for gopls. This PR adds the foundation for transitioning to use gopls and introduces a new option for
g:go_def_mode,gopls.lint before running tests
extract URI encoding function
Extract function to URI encode strings and add the decoding function,
too.
Use the new uri encoding function when reporting a GitHub issue.
changes. Lines starting
add gopls to tools
teach vim-go to get definition information from gopls
Fixes #2146