Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle restoration of windows environment variables correctly #2292

Merged
merged 1 commit into from
May 15, 2019

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented May 15, 2019

Fixes #2286

@bhcleek
Copy link
Collaborator Author

bhcleek commented May 15, 2019

@glebtv @aidanbrumsickle can you confirm that this works for you?

@aidanbrumsickle
Copy link

Looks good.

Deleted a few Go tool binaries and ran :GoInstallBinaries and it worked. I then did :GoBuild to make sure the go executable was still available, which it was, and I did :echo $PATH afterward and it was fine. Running :GoUpdateBinaries now since I believe that calls the same function.

@bhcleek bhcleek merged commit 9520201 into fatih:master May 15, 2019
@bhcleek
Copy link
Collaborator Author

bhcleek commented May 15, 2019

Thank you for the assistance!

@aidanbrumsickle
Copy link

Thanks for fixing it so quickly! I use this plugin all the time and it's been getting better and better.

@bhcleek
Copy link
Collaborator Author

bhcleek commented May 15, 2019

Thank you for the accolades. I'm trying hard to maintain high quality and resolve existing issues before adding anything new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoInstallBinaries does not work and breaks $PATH on windows
2 participants