lsp: support build tags #2429
Merged
lsp: support build tags #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the directory name match the package name in godef tests.
* pass the request id to newResponse * return the result message from newResponse
* rename go#lsp#message#workspaceFolders to make it clear that it returns a request result message * rename go#lsp#AddWorkspace to make it clear that it adds a directory and isn't necessarily related to any other context that may compose of workspace (of which there is none yet). * rename go#lsp#message#AddWorkspaces to make it reflect the fact that it changes workspace folders and add a new parameter to specify the directories to be removed.
* Tell gopls that vim-go supports the workspace.configuration client capability. * Respond to workspace/configuration requests with buildFlags and hoverKind. buildFlags is set to the build flags currently configured in vim-go build flags (e.g. g:go_build_flags). hoverKind is set to NoDocumentation so that hover responses won't return documentation.
Reset workspaces when build flags are changed via `:GoBuildFlags`. This won't yet do anything. Once https://go-review.googlesource.com/c/tools/+/187819 is merged, though, build flags that gopls uses will be able to be changed using `:GoBuildFlags` without requiring the Vim session to be restarted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
godef: make directory name match the package name
Make the directory name match the package name in godef tests.
lsp: fix response handling
lsp: refactor managing workspace directories
returns a request result message
and isn't necessarily related to any other context that may compose of
workspace (of which there is none yet).
it changes workspace folders and add a new parameter to specify the
directories to be removed.
lsp: add support for configuration client capability
capability.
hoverKind. buildFlags is set to the build flags currently configured
in vim-go build flags (e.g. g:go_build_flags). hoverKind is set to
NoDocumentation so that hover responses won't return documentation.
lsp: reset workspaces when build flags are changed
Reset workspaces when build flags are changed via
:GoBuildFlags. Thiswon't yet do anything. Once
https://go-review.googlesource.com/c/tools/+/187819 is merged, though,
build flags that gopls uses will be able to be changed using
:GoBuildFlagswithout requiring the Vim session to be restarted.