Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use COMSPEC to find cmd.exe. #2724

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Use COMSPEC to find cmd.exe. #2724

merged 1 commit into from
Feb 13, 2020

Conversation

drichardson
Copy link
Contributor

@drichardson drichardson commented Feb 13, 2020

PR #2712 constructed a path to cmd.exe, but there is a standard environment variable that points to cmd.exe, which is COMSPEC. This fix uses COMSPEC.

@drichardson drichardson changed the title Use COMSEC to find cmd.exe. Use COMSPEC to find cmd.exe. Feb 13, 2020
@bhcleek
Copy link
Collaborator

bhcleek commented Feb 13, 2020

Thanks for contributing again

@bhcleek bhcleek merged commit b8213ab into fatih:master Feb 13, 2020
bhcleek added a commit that referenced this pull request Feb 13, 2020
@bhcleek bhcleek added this to the vim-go 1.23 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants