lint: execute errcheck using ExecInDir #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execute errcheck using ExecInDir so that it will use the package of the current buffer. It looks like it was inadvertently changed from ExecInDir to Exec a long while ago when the exec functions were refactored. Add tests to verify more go#lint#Errcheck behvaviors. Fixes fatih#2725
bhcleek
force-pushed
the
lint/errcheck/options-no-package
branch
from
17dd529
to
c99b2f1
Compare
bhcleek
added a commit
that referenced
this pull request
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute errcheck using ExecInDir so that it will use the package of the
current buffer. It looks like it was inadvertently changed from
ExecInDir to Exec a long while ago when the exec functions were
refactored.
Fixes #2725