lsp: drop out of date diagnostics #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop out of date diagnostics so that highlighting will not be applied incorrectly. Running :GoImports was causing errors sometimes and causing highlighting to be applied on the wrong lines since it changed the source. Since formatting with gofmt or goimports will change the files, clear the diagnostic errors and warnings before reloading the buffer so that the BufWinEnter autocmd doesn't try to set the matches to the wrong locations. Send changes to gopls after formatting with gofmt or goimports so that gopls will have the current version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop out of date diagnostics so that highlighting will not be applied
incorrectly.
Running :GoImports was causing errors sometimes and
causing highlighting to be applied on the wrong lines since it changed
the source. Since formatting with gofmt or goimports will change the
files, clear the diagnostic errors and warnings before reloading the
buffer so that the BufWinEnter autocmd doesn't try to set the matches to
the wrong locations.
Send changes to gopls after formatting with gofmt or goimports so that
gopls will have the current version.