Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: install tools with go install instead of go get #3317

Merged
merged 3 commits into from
Nov 7, 2021

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Oct 25, 2021

plugin: install using go install instead of go get

Fixes #3316

plugin: remove unneeded selection

Remove unneeded check for module compatible tools; all tools that vim-go
uses use modules now.

plugin: simplify determination of the binary name

@bhcleek bhcleek added this to the vim-go 1.26 milestone Oct 26, 2021
@kevinburke
Copy link

Thanks for this change!

@bhcleek bhcleek merged commit 585e12d into fatih:master Nov 7, 2021
bhcleek added a commit that referenced this pull request Nov 7, 2021
@bhcleek bhcleek deleted the plugin/go-install branch November 7, 2021 17:08
@DeedleFake
Copy link

Any chance of this getting included in a release soon? Go 1.18 is out and :GoUpdateBinaries has completely stopped working. I fixed it temporarily by manually modifying plugin/go.vim directly in my vim-go installation, but I'd much prefer an official release for obvious reasons.

@bhcleek
Copy link
Collaborator Author

bhcleek commented Mar 20, 2022

I plan to cut an official release soon, but I try hard d to keep master stable. You should be fine running on latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:GoUpdateBinaries doesn't work on go 1.18
3 participants