Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: add support for generics #3397

Merged
merged 6 commits into from
Apr 13, 2022
Merged

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Apr 11, 2022

Add support for generics.

This is still in draft form, because I want to add tests to verify the correctness of these changes. This PR may change, but I welcome any early feedback. These changes are mostly untested thusfar; I can only confirm:

  1. the regular expressions close to what I intend.
  2. No errors from these changes popped up when I opened a Go file.

I do not anticipate force pushing any commits, but I will if I need to in order to keep the commit history clean and if the changes I need to make would be handled as fixup commits whose integration may cause conflicts.

Fixes #3394

@bhcleek bhcleek marked this pull request as ready for review April 13, 2022 08:24
@bhcleek bhcleek merged commit 080e44d into fatih:master Apr 13, 2022
@bhcleek bhcleek deleted the syntax/generics branch April 13, 2022 15:15
bhcleek added a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax: invalid highlighting of methods with generic receiver
1 participant