sameids: highlight package references correctly #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not assume that the length of each reference to an identifier is the same. This is important for packages where the references may be the import path or the package name. e.g. "net/http" and "http" reference the same package and gopls results include both forms.
Extract sameids functionality to its own file and eliminate the need for the guru adapter over the LSP handler result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sameids: fix handling of package identifiers
Do not assume that the length of each reference to an identifier is the
same. This is important for packages where the references may be the
import path or the package name. e.g. "net/http" and "http" reference
the same package and gopls results include both forms.
sameids: refactor same ids
Extract sameids functionality to its own file and eliminate the need for
the guru adapter over the LSP handler result.
Fixes #3468