Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import path for josharian/impl #3477

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Fix import path for josharian/impl #3477

merged 1 commit into from
Dec 31, 2022

Conversation

FooSoft
Copy link
Contributor

@FooSoft FooSoft commented Dec 23, 2022

Looks like josharian decided to rename the master branch to main, which unfortunately breaks the vim-go GoInstallBinaries / GoUpdateBinaries commands for that tool.

Updating the import path.

@bhcleek bhcleek added this to the vim-go v1.29 milestone Dec 23, 2022
@bhcleek
Copy link
Collaborator

bhcleek commented Dec 23, 2022

Thank you.

What problem are you actually seeing? I'm still able to install impl with :GoUpdateBinaries impl.

@FooSoft
Copy link
Contributor Author

FooSoft commented Dec 30, 2022

@bhcleek I'm not able to pull down impl because the master branch doesn't exist (and nvim complains about this when running :GoUpdateBinaries. I'm not sure why you aren't seeing this too.

Running git version 2.38.1 and go version 1.19.3 The rest of the tools end up getting pulled down without issue. Maybe related to me running NeoVim? Seems unlikely.

Screenshot from 2022-12-30 10-50-47

@bhcleek
Copy link
Collaborator

bhcleek commented Dec 30, 2022

Is your GOPROXY (i.e. go env GOPROXY) set to direct instead of https://proxy.golang.org,direct by chance?

@FooSoft
Copy link
Contributor Author

FooSoft commented Dec 30, 2022

It is indeed just set to direct, which I believe is the out-of-the-box default on Fedora (where I'm using this).

@bhcleek
Copy link
Collaborator

bhcleek commented Dec 30, 2022

Thank you for confirming. I'll merge very soon.

@bhcleek
Copy link
Collaborator

bhcleek commented Dec 31, 2022

FWIW, you can unset GOPROXY or explicitly set it to the default value, https://proxy.golang.org,direct, in order to work around this problem, too.

@bhcleek bhcleek merged commit ea4a766 into fatih:master Dec 31, 2022
bhcleek added a commit that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants