commands: use bang attribute to jump to errors #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using a custom global variable to control the behavior of jumpting to an error when we called any command in cmd.vim (such as :GoInstall, :GoTest, etc..) However we don't need this actually because the default :make command in vim has the behavior of no jumping to the error when the `!` attribute is passed to the command, i.e: `:make!`. We have this feature already for `:GoBuild` and `:GoRun` but those were also conflicting with out manual `g:go_jump_to_error` setting. Basically even if you call `:GoBuild` (without `!`) it would not jump if `g:go_jump_to_error` was set to `0`. This PR adds the bang attribute, removes the `go_jump_to_error` setting for the following commands: * `:GoBuild` * `:GoRun` * `:GoInstall` * `:GoTest` * `:GoTestFunc` * `:GoTestCompile` * `:GoVet` * `:GoCoverage` Now basically the behavior is just like `:make`: * `GoBuild` jumps to the error * `GoBuild!` does not jump to the error
|
This is good to go. |
fatih
added a commit
that referenced
this pull request
May 26, 2015
commands: use bang attribute to jump to errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using a custom global variable to control the
behavior of jumpting to an error when we called any command in cmd.vim
(such as :GoInstall, :GoTest, etc..)
However we don't need this actually because the default :make command
in vim has the behavior of no jumping to the error when the
!attributeis passed to the command, i.e:
:make!. We have this feature alreadyfor
:GoBuildand:GoRunbut those were also conflicting with ourmanual
g:go_jump_to_errorsetting. Basically even if you call:GoBuild(without!) it would not jump ifg:go_jump_to_errorwasset to
0.This PR adds the bang attribute, removes the
go_jump_to_errorsettingfor the following commands:
:GoBuild:GoRun:GoInstall:GoTest:GoTestFunc:GoTestCompile:GoVet:GoCoverageNow basically the behavior is just like
:make::GoBuildjumps to the error:GoBuild!does not jump to the errorRelates issue #440