Do not add log output to quickfix list #561
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem where the output of
log.Println
was added to the quickfix window when some tests failed. Here is some example code the reproduce the issue:When the tests were run with
:GoTest
or:GoTest!
thelog.Println
line was included in the quickfix list, which looked like this:My guess was that the regex that's responsible for parsing the output was not meant to parse the log line, but only did so accidently.
So I changed the regex to only parse lines for filenames and linenumbers that begin with at least one whitespace (which log lines do not).
(See the commit message for more details)
What do you think? :)