Add GoOracleTags command to set build tags for oracle #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonotes
force-pushed
the
master
branch
2 times, most recently
from
97d4aba
to
d010758
Compare
|
Hi @gonotes Thanks for this addition. After that a couple of things:
I also going to make comments to the PR, please fix them too. |
| @@ -115,6 +121,7 @@ func! s:RunOracle(mode, selected, needs_package) range abort | |||
| " info check Oracle's User Manual section about scopes: | |||
| " https://docs.google.com/document/d/1SLk36YRjjMgKqe490mSRzOPYEDe0Y_WQNRv-EiFYUyw/view#heading=h.nwso96pj07q8 | |||
| let cmd .= ' ' . go#util#Shelljoin(scopes) | |||
| " echon "vim-go: " | echohl Function | echon "current cmd is: '". cmd ."'" | echohl None | |||
gonotes
force-pushed
the
master
branch
2 times, most recently
from
d9548ce
to
d010758
Compare
gonotes
changed the title
|
@gonotes This is not mergable right now, fyi |
|
@fatih Conflit has been resolved.Many thanks for your help,this is my first time commit PR. |
fatih
added a commit
that referenced
this pull request
Nov 15, 2015
Add GoOracleTags command to set build tags for oracle
|
Thanks @gonotes. Just came back, sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I reading docker source code, which locate in github.com/docker/docker/docker directory, I could not use GoReferrer to find "mainDaemon" when docker as daemon.What I found is client code when docker as client and without golang build tags "daemon".
So I try to add GoTags command,which can set oracle command param "-tags",then thing goes well!