Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for TabBar with Gotags #60

Closed
wants to merge 1 commit into from

Conversation

ceocoder
Copy link
Contributor

@fatih - Thank you for the plugin, I added support for TagBar after reading this


will yield something like this,
![tagbar](http://i.imgur.com/1tdkDGZ.png)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a tagbar related thing. Can you remove this section completely? I'm going to include a gif with some predefined screenshots and they all need to be consistent :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

@fatih
Copy link
Owner

fatih commented Apr 23, 2014

Thanks, I've had a plan to add a feature for that, see #59. Let's see what we can do here.

\ },
\ 'ctagsbin' : 'gotags',
\ 'ctagsargs' : '-sort -silent'
\ }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a wrong approach. Look at gosnippet.vim where I've checking for the plugin itself and then defining the settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - added to plugins/ and added check if the plugin was installed. Thank you.

@fatih
Copy link
Owner

fatih commented Apr 23, 2014

Btw I have a plan to include this, if you can wait a little I'm going to implement this asap.

    * check if the plugin installed under plugins or bundles
@fatih
Copy link
Owner

fatih commented Apr 27, 2014

There are several problems with this pull request:

  • You need to check for plugin/tagbar.vim not plugin/tagbar
  • You only can return from a function. You need to call finish if you use a simple if clause. This works for me:
if globpath(&rtp, 'plugin/tagbar.vim') == ""
    finish
endif

@fatih fatih mentioned this pull request Apr 28, 2014
@BenjaminRH
Copy link

+1

1 similar comment
@weitzj
Copy link

weitzj commented May 8, 2014

+1

@fatih
Copy link
Owner

fatih commented May 14, 2014

Thanks for your support @ceocoder your changes are merged with the changes from @smeggingsmegger

@fatih fatih closed this May 14, 2014
@ceocoder
Copy link
Contributor Author

@fatih sorry about abandoning this PR - and thank you @smeggingsmegger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants