util: add auto quickfix window height for errors [GH-592] #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih
force-pushed
the
auto-height-quickfix
branch
from
f0897c8
to
1fe325f
Compare
Right now we are just calling `cwindow` without any arguments. By default Vim opens a view with an height of 10. But this doesn't look good if you have only one single error. It also takes display estate for small screens. This PR introduces a new feature, which automatically resizes the quickfix error for the number of errors. However to prevent consuming all the view, it's capped at 10 lines (the default Vim value). We also have a new setting, `g:go_quickfix_height` which let us to give an explicit window height. If set, automatic resize is enabled and the height will be always the value of `g:go_quickfix_height`. Closes #592
fatih
force-pushed
the
auto-height-quickfix
branch
from
1fe325f
to
d5a1dff
Compare
fatih
added a commit
that referenced
this pull request
Nov 16, 2015
util: add auto quickfix window height for errors [GH-592]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are just calling
cwindowwithout any arguments. Bydefault Vim opens a view with an height of 10. But this doesn't look
good if you have only on single error. It also takes display estate for
small screens.
This PR introduces a new feature, which automatically resizes the
quickfix error for the number of errors. However to prevent consuming
all the view, it's capped at 10 lines (the default Vim value).
We also have a new setting,
g:go_quickfix_heightwhich let us to givean explicit window height. If set, automatic resize is enabled and the
height will be always the value of
g:go_quickfix_height.Previous case:
Improved case (auto height feature):
Closes #592