Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax highlighting for //go:generate #757

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Conversation

mhamrle
Copy link
Contributor

@mhamrle mhamrle commented Mar 10, 2016

Fixes: #487

@fatih
Copy link
Owner

fatih commented Mar 13, 2016

Thanks @mhamrle

Can you please put it behind a flag, like https://github.com/mhamrle/vim-go/blob/generate/syntax/go.vim#L311 and make it disabled by default? This is new and we don't enable syntax highlighting by default. Thanks!

@mdlayher can you try this and see how it works for you?

@mdlayher
Copy link

Looks great to me! Thanks a ton for your work.

@fatih
Copy link
Owner

fatih commented Mar 16, 2016

@mhamrle mind adding the setting ? I can merge afterwards

@mdlayher thanks for the comment 👍

@mhamrle
Copy link
Contributor Author

mhamrle commented Mar 16, 2016

@fatih done, please check

fatih added a commit that referenced this pull request Mar 16, 2016
syntax highlighting for //go:generate
@fatih fatih merged commit 6e1072e into fatih:master Mar 16, 2016
@fatih
Copy link
Owner

fatih commented Mar 16, 2016

Great addition, thanks @mhamrle 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants