refactored duplicate offset functions #762
Conversation
| function! go#complete#GetInfo() | ||
| let offset = go#complete#gocodeCursor()+1 | ||
| return go#complete#GetInfoFromOffset(offset) | ||
| endfunction |
There was a problem hiding this comment.
This is a public function that people use, for example to plugin into statusline or use for their own functions.
There was a problem hiding this comment.
The function is still there, I renamed the top one.
|
Hi @nhooyr, did you also checked out which implementation is the correct one? Or are they really all the same? |
|
|
||
| let argOff = "-o=" . offs | ||
| return argOff | ||
| return "-o=" . go#util#OffsetCursor() |
There was a problem hiding this comment.
I think we should remove s:getOffset() and change def.vim to make it that it uses this directly if possible.
|
@fatih all are the basically the exact same as far as I can tell. |
|
updated based on feedback. |
|
Thanks @nhooyr I need to test this myself, If everything works as intended, I'll merge it. |
|
@fatih ok. here are the differences, the ones in rename.vim and oracle.vim were the exact same. They were copies of the |
refactored duplicate offset functions
|
Thanks @nhooyr , great refactor, much appreciated 👍 |
Closes #719