Add custom godef jump stack (fixes #667) #776
Conversation
|
How does this look so far? The UI integration took the longest and required the deepest modifications, but the result is much cleaner. Obviously, it needs some more testing, and I will continue to push changes if I find any issues. Also, I'm not terribly keen on having the current line and cursor highlighted in the non-interactive mode, and would like to change that to behave more light a pager. Thoughts/feedback? |
|
Hi @alaska I was absent on the weekend. I'll look into this soon! |
| vsplit | ||
| else | ||
| " We didn't get a mode, so we start the process of pushing to the | ||
| " jumpstack |
There was a problem hiding this comment.
So does it mean when I open a split view, we'll not going to use the jumpstack ?
There was a problem hiding this comment.
That's correct. I was trying to avoid inconsistent behavior, but I have just thought of a better way to do this that will push the location AFTER the jump, so that each new window gets its own stack that starts from the first location visited.
autoload/go/def.vim: - Fix Jump stack to work across windows. That is, if you issue a split or tab jump, you will enter a new window with a new jump stack starting from where you were - Changes to remove :GoDefStack. go#def#StackUI() is always interactive now. Add more informative help message and mappings autoload/go/ui.vim: - defaulting to content length in all cases - add an echon to remove confusing message from command line doc/vim-go.txt: - Changes to remove :GoDefStack. - Move :GoDefJump to directly after :GoDef, because it now shares the job of describing the stack ftplugin/go/commands.vim: - remove :GoDefStack
|
All requested changes have been made. In this version, the jumpstack starts new in new splits/tabs with one entry, which is the location you left. Do you think this is the proper behavior, or should the stack be empty? |
|
Hi @alaska This seems to be working well. I'm using it now. Probably going to merge it today/tomorrowy and then will do some changes to make it compatible with the new |
|
Thanks! I'm still on the fence about whether the stack should be empty in a new split/tab or not. I'm leaning towards not, since the location you jumped from would still be in the window you left, and popping would then leave you with two splits on the same buffer, but I can see how some folks might find it useful. |
|
About that. I think we need a command to clear the stack. Let's do it manual. Basically we should be able to set the entry point ourselves. Best way is doing it like:
The reason is that split or tab is not a boundary. For example I do a lot |
|
There is a weird error. Suppose you called |
|
@alaska I'm merging this and going to open another PR inside the guru pr to fix some of the style changes and co. That would make it easier for us. Thanks a lot again for the idea and working on this 👍 |
Unified and updated PR