Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: filter out warnings from the mail gem #6

Merged

Conversation

olleolleolle
Copy link
Contributor

These warnings are not relevant to the output, but dominate it.

I borrowed the Warning example from the Ruby documentation.

olleolleolle and others added 3 commits November 24, 2023 20:01
These warnings are not relevant to the output, but dominate it.

I borrowed the Warning example from the Ruby documentation.
@fatkodima
Copy link
Owner

Seems like mail gem will never fix these warnings. 🙄

@fatkodima fatkodima merged commit da8bd12 into fatkodima:master Nov 24, 2023
4 checks passed
@olleolleolle olleolleolle deleted the test-ignore-warnings-from-other-gem branch November 24, 2023 19:48
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Nov 24, 2023

@fatkodima Nice improvements!

Now, there are more output lines than warning lines, at least.

Run bundle exec rake test
/home/runner/work/data_checks/data_checks/vendor/bundle/ruby/3.2.0/gems/mail-2.8.1/lib/mail/parsers/date_time_parser.rb:837: warning: statement not reached
/home/runner/work/data_checks/data_checks/vendor/bundle/ruby/3.2.0/gems/mail-2.8.1/lib/mail/parsers/date_time_parser.rb:691: warning: assigned but unused variable - testEof
Run options: --seed 14750

# Running:

.............................................................

Finished in 0.408193s, 149.4390 runs/s, 489.9640 assertions/s.
61 runs, 200 assertions, 0 failures, 0 errors, 0 skips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants