Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not exit with correct exit code #23

Closed
fatso83 opened this issue Mar 26, 2020 · 1 comment · Fixed by sinonjs/sinon#2439
Closed

Does not exit with correct exit code #23

fatso83 opened this issue Mar 26, 2020 · 1 comment · Fixed by sinonjs/sinon#2439
Assignees
Labels
bug Something isn't working

Comments

@fatso83
Copy link
Owner

fatso83 commented Mar 26, 2020

Usually a test runner that has failing test will have an exit code of non-zero (like 1) when exiting. This does not, meaning that when it fails one is unable to inspect the error code to determine if there were failing tests.

@fatso83
Copy link
Owner Author

fatso83 commented Mar 26, 2020

@rpgeeganage I am no longer able to modify the code at this point 😿 I am not even able to find out where the test runner starts. Some sprinkled comments here and there would have helped 😸

After trying to analyze this, I am guessing the reporter could keep some internal failure counter and then when Processor#task is finally finished it can ask the reporter for the failure count and exit with process.exit(1) if it is > 0?

@rpgeeganage rpgeeganage added the bug Something isn't working label Dec 23, 2020
fatso83 added a commit that referenced this issue Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants