Fix bad initial value for Yamamoto method #76
Conversation
There was a problem hiding this comment.
Thanks for taking care of this!
Please use separate commits for formatting and fixing issues.
In terms of style, I agree, we should probably update the entire code base with a linter such as ruff. There are, however some cases where I'd like to not use the default settings. E.g., I really dislike the way it uses linebreaks with parenthesis (see separate comment).
Change initial value from the automatic middle of the boundary space (500 & 500) to (1, 1), as an initial value of 500 can lead to numerical errors.
ronald-jaepel
force-pushed
the
fix/yamamoto_bad_initial_value
branch
from
705aef8
to
d428e9e
Compare
|
Alright. I'd then tend to use a separate PR for formatting changes. I've therefore removed the formatting changes from this PR and it reduces down to one commit. |
|
Hey, I just saw that this was merged into master. While not a problem here, let's try to set |
|
Oh, and please use the "rebase and squash" option. |
|
Ah, damn, sorry! My bad!
…On Mon, 4 Dec 2023, 10:31 Johannes Schmölder, ***@***.***> wrote:
Oh, and please use the "rebase and squash" option.
—
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEJ4NDXY2YFZBHVSCRZGUI3YHWJ7XAVCNFSM6AAAAABAC6LR7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZYGE2TMNJSHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
Change initial value from the automatic middle of the boundary space (500 & 500) to (1, 1), as an initial value of 500 can lead to numerical errors.
Also adapted yamamoto.py to PEP8.