Improve preprocessing time #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmoelder
commented
Dec 11, 2023
| @@ -128,13 +128,10 @@ def add_inter_zone_connections(self, flow_sheet): | |||
|
|
|||
| flow_sheet.add_connection(origin, destination) | |||
|
|
|||
| flow_rates = self.flow_sheet.get_flow_rates() | |||
| for zone in self.zones: | |||
There was a problem hiding this comment.
I wonder if this is even necessary here. I think that output states are entirely handled by Events.
schmoelder
force-pushed
the
benchmarking_carousel
branch
from
0479cd4
to
ddd1b24
Compare
|
@dion-is, happy new year! :) Did you ever get a chance to test this PR? |
|
@schmoelder , sorry, I just rolled back to the previous version for now. Will test this later. |
schmoelder
force-pushed
the
dev
branch
2 times, most recently
from
cf5243a
to
c5f20f8
Compare
schmoelder
force-pushed
the
benchmarking_carousel
branch
from
ddd1b24
to
24be4d5
Compare
schmoelder
force-pushed
the
benchmarking_carousel
branch
from
24be4d5
to
c8551f7
Compare
schmoelder
force-pushed
the
dev
branch
2 times, most recently
from
a3e6c69
to
1f55438
Compare
schmoelder
force-pushed
the
benchmarking_carousel
branch
2 times, most recently
from
763fe31
to
ef4ac2b
Compare
schmoelder
force-pushed
the
benchmarking_carousel
branch
from
ef4ac2b
to
1eac549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #75, pre-processing can take a long time, especially for complex systems with many units and parameters. In this PR, we try to address some of the issues.
Options
Consider further profiling to identify current bottlenecks and consider architecture changes that further speed this up