Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of initial values #84

Merged
merged 9 commits into from Jan 10, 2024

Conversation

ronald-jaepel
Copy link
Collaborator

@ronald-jaepel ronald-jaepel commented Jan 9, 2024

Solve inconsistencies if x0 includes dependent variables.

Now:
x0 expects only independents in untransformed space. Will recompute dependents with warning if provided.
optimization_problem.create_initial_values() has optional flag include_dependent_variables=True to return dependent variables.

ToDos:

  • move chebychev to own method
  • migrate checks for x0 from pymoo adapter to optimizer.optimize
  • add more tests for initial values with dependencies in testing suite
  • Check documentation (especially where create_initial_values is used)

@ronald-jaepel ronald-jaepel force-pushed the fix/initial_values_with_dependencies branch 2 times, most recently from 301543a to 7014e67 Compare January 10, 2024 10:28
@schmoelder schmoelder force-pushed the fix/initial_values_with_dependencies branch 2 times, most recently from ac1a735 to 371ea0d Compare January 10, 2024 12:56
@schmoelder schmoelder force-pushed the fix/callbacks_with_dependencies branch from a83d94b to 0590729 Compare January 10, 2024 12:56
@schmoelder schmoelder force-pushed the fix/initial_values_with_dependencies branch from 371ea0d to 65b583a Compare January 10, 2024 12:57
@schmoelder schmoelder changed the title Accept "full" x for x0 argument, i.e. including dependent variables. Improve handling of initial values Jan 10, 2024
Base automatically changed from fix/callbacks_with_dependencies to dev January 10, 2024 14:15
@schmoelder schmoelder force-pushed the fix/initial_values_with_dependencies branch from 65b583a to c123e41 Compare January 10, 2024 14:19
@schmoelder schmoelder force-pushed the fix/initial_values_with_dependencies branch from ceb00c9 to f4175af Compare January 10, 2024 15:24
@schmoelder schmoelder force-pushed the fix/initial_values_with_dependencies branch from 9088a7b to be1330c Compare January 10, 2024 18:04
@schmoelder schmoelder merged commit a0b56e8 into dev Jan 10, 2024
5 checks passed
@schmoelder schmoelder deleted the fix/initial_values_with_dependencies branch January 10, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants