failure resolving implicit package name

[FND]

reduced test case:

// faucet.config.js
module.exports = {
    static: [{
        source: "material-design-icons/iconfont",
        target: "./dist/fonts"
    }]
};

$ npm install -D faucet-pipeline-static
$ npm install material-design-icons
$ ./node_modules/.bin/faucet
ERROR: could not resolve `"material-design-icons/iconfont"`

yet source: "./node_modules/material-design-icons/iconfont" works as expected

it appears the error occurs in require.resolve: faucet-core:resolve.js:38 (via l. 23)

require.resolve("material-design-icons", { paths: ["/path/to/root"] })

this is because the iconfont sub-directory does not contain an index.js file - meaning faucet-core's resolvePath is insufficiently generic

tested with Node v11.9.0

[moonglum]

Does this still apply now that we use the real resolve due to dropping older Node versions? 🤔

[FND]

Well, given that the issue occurs with Node's own require.resolve (which expects an index.js, apparently) and was confirmed with v11, I would think it's still relevant.

I was uncertain, so have set up a minimal test case that confirms this:
https://github.com/faucet-pipeline/faucet-pipeline-core/commits/testcase-resolve
(note the commit messages and two different CI results)

Thus it seems faucet-pipeline/faucet-pipeline-core@90a022c is not relevant.

[FND]

fixed in faucet-core v1.5.1 (faucet-pipeline/faucet-pipeline-core@685eefa)