Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port status #40

Merged
merged 11 commits into from
Sep 26, 2018
Merged

Port status #40

merged 11 commits into from
Sep 26, 2018

Conversation

Bairdo
Copy link
Contributor

@Bairdo Bairdo commented Sep 18, 2018

goes on top of #39
and adds an interface for faucet to notify chewie of port status changes

@Bairdo Bairdo changed the title Port status WIP - Port status Sep 19, 2018
@Bairdo
Copy link
Contributor Author

Bairdo commented Sep 19, 2018

Needs to set sm.portEnabled when port is up again. ATM i'm trying to get preemptive Identity Requests to be sent on port up.

@Bairdo
Copy link
Contributor Author

Bairdo commented Sep 21, 2018

Fixes #42 (timer scheduler).

Think preemptively sending identity requests on port up will need to be a separate PR. (issue #46)

@Bairdo
Copy link
Contributor Author

Bairdo commented Sep 21, 2018

closes #36

@byllyfish
Copy link
Contributor

Just a heads up since I've been porting chewie to asyncio. Once you're confident in the heap-based scheduler, it would be worthwhile to refactor the scheduler into its own class (hiding the heap-based details):

An API that mirrored an event_loop call_later might look like this:

class TimerScheduler:
def call_later(self, timeout, func, *args): ...
def run(self): ...

https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.call_later

This is not urgent, and I can submit a separate PR after this is pulled into master.

@Bairdo Bairdo force-pushed the port-status branch 3 times, most recently from eea7f67 to b1e0aba Compare September 24, 2018 23:36
@Bairdo
Copy link
Contributor Author

Bairdo commented Sep 24, 2018

thanks for the suggestion.

this could be merged

@Bairdo Bairdo changed the title WIP - Port status Port status Sep 24, 2018
@anarkiwi anarkiwi merged commit 97a0fbd into faucetsdn:master Sep 26, 2018
@Bairdo Bairdo deleted the port-status branch September 26, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants