CodeCheck - Part2b

[mwutzke]

More horizontal white-space / alignment cleanups

[codecov]

Codecov Report

Merging #3907 (fd0fba2) into master (1a3e23b) will not change coverage.
The diff coverage is 80.85%.

@@           Coverage Diff           @@
##           master    #3907   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          47       47           
  Lines        8877     8877           
=======================================
  Hits         8209     8209           
  Misses        668      668           

Impacted Files	Coverage Δ
faucet/faucet_bgp.py	89.33% <0.00%> (ø)
faucet/valve_ryuapp.py	75.00% <ø> (ø)
faucet/valve_util.py	83.33% <0.00%> (ø)
faucet/watcher.py	82.86% <ø> (ø)
faucet/config_parser_util.py	91.45% <33.33%> (ø)
faucet/gauge_prom.py	62.24% <33.33%> (ø)
faucet/faucet_event.py	60.47% <50.00%> (ø)
faucet/conf.py	97.97% <100.00%> (ø)
faucet/config_parser.py	94.74% <100.00%> (ø)
faucet/faucet_metrics.py	100.00% <100.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3e23b...fd0fba2. Read the comment docs.

[cglewis]

I can’t see why this PR would cause the integration test to fail. Must be a flake?

[mwutzke]

My local re-run passes as well:

test results
============
---
mininet_multidp_tests.FaucetSingleStackStringOfDPTagged0Test.test_dp_root_hop_port:
  output: ''
  status: OK
  test_duration_secs: 62
...

[cglewis]

@mwutzke looks like retriggering passed. If you could open an issue so we can track the flake, I can merge this in for now.

[mwutzke]

Created issue #3908 to track the earlier test run failure.